JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
19 stars 12 forks source link

chore: add cors origin env #4823

Closed mikeallisonJS closed 2 weeks ago

mikeallisonJS commented 2 weeks ago

Description

Issue

Need cors origin in order to use mux

Solution

Add CORS_ORIGIN env to terraform

linear[bot] commented 2 weeks ago

ENG-1700 Add missing CORS_ORIGIN to api-media infra-no-qa

jesus-film-bot commented 2 weeks ago

Ran Plan for dir: infrastructure workspace: default

Plan Failed: This project is currently locked by an unapplied plan from pull #4485. To continue, delete the lock from #4485 or apply that plan and merge the pull request.

Once the lock is released, comment atlantis plan here to re-plan.

mikeallisonJS commented 2 weeks ago

atlantis plan

jesus-film-bot commented 2 weeks ago

Ran Plan for dir: infrastructure workspace: default

Show Output ```diff Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: ~ update in-place - destroy +/- create replacement and then destroy Terraform will perform the following actions: # module.datadog.module.datadog_log_forwarder.aws_lambda_function.this[0] will be updated in-place ~ resource "aws_lambda_function" "this" { id = "datadog-log-forwarder" tags = { "DD_FORWARDER_VERSION" = "3.73.0" } # (30 unchanged attributes hidden) ~ environment { # Warning: this attribute value will be marked as sensitive and will not # display in UI output after applying this change. The value is unchanged. ~ variables = (sensitive value) } # (2 unchanged blocks hidden) } # module.datadog.module.datadog_rds_enhanced_monitoring_forwarder.aws_lambda_function.this[0] will be updated in-place ~ resource "aws_lambda_function" "this" { id = "datadog-rds-enhanced-monitoring-forwarder" tags = { "DD_FORWARDER_VERSION" = "3.73.0" } # (28 unchanged attributes hidden) ~ environment { # Warning: this attribute value will be marked as sensitive and will not # display in UI output after applying this change. The value is unchanged. ~ variables = (sensitive value) } # (2 unchanged blocks hidden) } # module.stage.module.api-journeys.module.ecs-task.aws_ecs_service.ecs_service will be updated in-place ~ resource "aws_ecs_service" "ecs_service" { id = "arn:aws:ecs:us-east-2:410965620680:service/jfp-ecs-cluster-stage/api-journeys-stage-service" name = "api-journeys-stage-service" tags = {} ~ task_definition = "arn:aws:ecs:us-east-2:410965620680:task-definition/jfp-api-journeys-stage:47" -> (known after apply) # (15 unchanged attributes hidden) # (4 unchanged blocks hidden) } # module.stage.module.api-journeys.module.ecs-task.aws_ecs_task_definition.ecs_task_definition must be replaced +/- resource "aws_ecs_task_definition" "ecs_task_definition" { ~ arn = "arn:aws:ecs:us-east-2:410965620680:task-definition/jfp-api-journeys-stage:47" -> (known after apply) ~ arn_without_revision = "arn:aws:ecs:us-east-2:410965620680:task-definition/jfp-api-journeys-stage" -> (known after apply) ~ container_definitions = jsonencode( ~ [ ~ { name = "jfp-api-journeys-stage-app" ~ secrets = [ # (11 unchanged elements hidden) { name = "JOURNEYS_ADMIN_URL" valueFrom = "arn:aws:ssm:us-east-2:410965620680:parameter/ecs/api-journeys/stage/JOURNEYS_ADMIN_URL" }, - { - name = "JOURNEYS_SHORTLINK_DOMAIN" - valueFrom = "arn:aws:ssm:us-east-2:410965620680:parameter/ecs/api-journeys/stage/JOURNEYS_SHORTLINK_DOMAIN" }, { name = "MAILCHIMP_AUDIENCE_ID" valueFrom = "arn:aws:ssm:us-east-2:410965620680:parameter/ecs/api-journeys/stage/MAILCHIMP_AUDIENCE_ID" }, # (23 unchanged elements hidden) ] - systemControls = [] # (9 unchanged attributes hidden) }, ~ { name = "jfp-api-journeys-stage-datadog-agent" - systemControls = [] # (10 unchanged attributes hidden) }, ~ { name = "jfp-api-journeys-stage-log-router" - systemControls = [] # (11 unchanged attributes hidden) }, ] # forces replacement ) ~ id = "jfp-api-journeys-stage" -> (known after apply) ~ revision = 47 -> (known after apply) - tags = {} -> null ~ tags_all = {} -> (known after apply) # (10 unchanged attributes hidden) } # module.stage.module.api-journeys.module.ecs-task.aws_ssm_parameter.parameters["JOURNEYS_SHORTLINK_DOMAIN"] will be destroyed # (because key ["JOURNEYS_SHORTLINK_DOMAIN"] is not in for_each map) - resource "aws_ssm_parameter" "parameters" { - arn = "arn:aws:ssm:us-east-2:410965620680:parameter/ecs/api-journeys/stage/JOURNEYS_SHORTLINK_DOMAIN" -> null - data_type = "text" -> null - id = "/ecs/api-journeys/stage/JOURNEYS_SHORTLINK_DOMAIN" -> null - key_id = "alias/aws/ssm" -> null - name = "/ecs/api-journeys/stage/JOURNEYS_SHORTLINK_DOMAIN" -> null - overwrite = true -> null - tags = { - "name" = "JOURNEYS_SHORTLINK_DOMAIN" } -> null - tags_all = { - "name" = "JOURNEYS_SHORTLINK_DOMAIN" } -> null - tier = "Standard" -> null - type = "SecureString" -> null - value = (sensitive value) -> null - version = 2 -> null # (2 unchanged attributes hidden) } Plan: 1 to add, 3 to change, 2 to destroy. ```

jesus-film-bot commented 2 weeks ago

Locks and plans deleted for the projects and workspaces modified in this pull request: