JetBrains / Nitra

Public Nitra repository
Other
554 stars 43 forks source link

Build instructions is incomplete and not fully described #40

Open ghost opened 9 years ago

ghost commented 9 years ago

Build instructions is incomplete and not fully described. Listed BuildBoot.cmd did not build everything what needed. So - it is completely missed any build automation.

General thoughts about build, after fighting with nitra build, and as result anyway i'm got build error. So i'm even can't report error, 'cause it is possible that there is something wrong in build.

There is exist common assumptions what are violated during by build and current instructions:

  1. Do not require administrative privileges.
  2. Do not change global state.
  3. Provide correct integration to build dependencies (if them should be built).
  4. Do not expose developer environment to build environment or production environment (i.e. do not assume that your developer workflow and configuration are good for others) - this is about magical environment variables, magical install locations. All of them should be collected or passed during build automation.

In facts:

  1. Nemerle dependency is subject to be built because changes in nemerle happens as part of nitra development => provide nemerle build automation.
  2. Reference dependencies by tags or commits. Yours nitra builds should not be becomes to be broken with (upstream) nemerle changes.
  3. Nemerle itself tries to install itself on default install location, at least if it is built with DevBuildQuick-4*.cmd as listed in build instructions.

Visual Studio: Visual studio integration is important part during development, and as goal of development, but it is completely not needed to build nitra and use nitra during build process of other software. So build VS integration should be optional (and for nemerle too).