search

JetBrains / TeamCity.VSTest.TestAdapter

Apache License 2.0
30 stars 14 forks source link

Removing TEAMCITY_PROJECT_NAME environment variable breaks other tools #43

Open cezarypiatekGC opened 2 years ago

cezarypiatekGC commented 2 years ago

Hi,

Can anyone explain why the TEAMCITY_PROJECT_NAME env variable is removed by this test adapter?

https://github.com/JetBrains/TeamCity.VSTest.TestAdapter/blob/0716fdfa15f5d0c1babc399c1231c944871e1050/TeamCity.VSTest.TestLogger/Options.cs#L55

The lack of this variable breaks other tools (for example ApprovalTests) which relays on this variable while discovering TC context.

Kind Regards, Cezary

NikolayPianikov commented 2 years ago

Because some tools (for instance xUnit) use this variable and break TeamCity integration. It is better to use TEAMCITY_VERSION instead. I've created the PR: https://github.com/approvals/ApprovalTests.Net/pull/617

cezarypiatekGC commented 11 months ago

It's over a year since I reported the issue and I again hit the problem that TEAMCITY_PROJECT_NAME is not available. Please restore this variable. If xUnit integration with TC is broken, then xUnit should be fixed instead of breaking everything around.