JimHagan / wwwsqldesigner

Automatically exported from code.google.com/p/wwwsqldesigner
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

SQL code generation needs to quote table names but doesn't #186

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a table named "Order"
2. Using the Load/Save dialog, Generate SQL for sqlite.

The actual output:
  CREATE TABLE Order ( ...
The correct output:
  CREATE TABLE 'Order' ( ...

I am using the demo from http://ondras.zarovi.cz/sql/demo/
Can't tell which version it is - would be nice if it would appear somewhere on 
the web page.

Please provide any additional information below.
If you fix this (I don't expect so, but thanks for this great tool anyway!), 
remember to escape table names in other places as well, e.g. when writing 
references such as:

  id_Order INTEGER DEFAULT NULL REFERENCES 'Order' (id),

Original issue reported on code.google.com by tempelmann@gmail.com on 21 Nov 2014 at 1:24

GoogleCodeExporter commented 9 years ago
Makes sense, will fix that. The SQLite XSL is a contributed code, I will have 
to study it first.

Original comment by ondrej.zara on 24 Nov 2014 at 8:39

GoogleCodeExporter commented 9 years ago
If you fix it, please also update the code at  
http://ondras.zarovi.cz/sql/demo/, and add a way to show the current version, 
please. Thanks again.

Original comment by tempelmann@gmail.com on 24 Nov 2014 at 8:49

GoogleCodeExporter commented 9 years ago
The demo installation always corresponds to the latest mercurial commit. I 
believed I fixed this, can you please test and confirm?

You might want to clear your browser's cache or force-reload the 
http://ondras.zarovi.cz/sql/demo/db/sqlite/output.xsl file.

Original comment by ondrej.zara on 24 Nov 2014 at 9:40

GoogleCodeExporter commented 9 years ago
Works! Many thanks for the quick fix.

Original comment by tempelmann@gmail.com on 24 Nov 2014 at 10:41

GoogleCodeExporter commented 9 years ago

Original comment by ondrej.zara on 24 Nov 2014 at 2:05