search

Jnjy / pe

0 stars 0 forks source link

Duplicate check may not be logical #2

Open Jnjy opened 1 year ago

Jnjy commented 1 year ago

Steps to reproduce:

  1. add n/Apple r/Web Developer s/New d/2023-02-01 t/Front-End
  2. add n/Apple r/Web Developer s/New d/2023-02-01 t/Back-End

Checking duplicates for same company, date, role and status may not be extensive enough for the user. From my understanding, many big companies have the same role (e.g. software engineer as general role name) focuses on different work, for example, back-end and front-end. My suggestion would be try to check duplicate based on the specific role.

Severity low is given as it does not affect the functionality of the application.

nus-pe-bot commented 1 year ago

Team's Response

Hi there! Thanks for writing in.

Our team believes that your main concern lies with how we consider 2 internships as duplicates. You believe that two internships with different tags should be considered as separate internships. Hence, you gave the example of two Apple internships that differ just based on their tags. We would like to highlight 2 main points.

Firstly, in the industry, most if not all companies specify the differences between 2 internships in the name of the role. Let us consider how Google and Tik Tok display their job listings, where similar roles would have their differences specified in the role name.

Google

image.png

Tik Tok

image.png

Secondly, tags are labels that a user can associate with an entry. They are just a convenient way that the user can use to identify certain keywords with the entry.

Taking into account the two points above, our team feels that the argument for using tags as a factor in differentiating internships is not a strong one. Instead, differences between entries should be highlighted using the essential fields. Thus, we stick by our original implementation of detecting duplicate internships, and hence would not classify this as a bug. Nevertheless, thanks for your time!

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Logical flaw with the feature for adding an internship position to the same company

Screenshot 2023-04-14 at 3.10.18 PM.png

Screenshot 2023-04-14 at 3.10.34 PM.png

I understand that the group has stated in the userguide that the 2 inputs I have put into the app are considered duplicates since the essential fields are the same, however, from a logical perspective, if the company is as big as apple or google , they may have different engineer roles that require knowledge of different languages, such as c++ or java, thus it is feasible to have 2 different engineer roles in the company that could have different requirements for it. Not a big issue, the whole app still works with this issue.

[original: nus-cs2103-AY2223S2/pe-interim#3903] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi there! Thanks for writing in.

Our team believes that your main concern lies with how we consider 2 internships as duplicates. You believe that two internships with different tags should be considered as separate internships. Hence, you gave the example of two Googe internships that differ just based on their tags. We would like to highlight 2 main points.

Firstly, in the industry, most if not all companies specify the differences between 2 internships in the name of the role. Let us consider how Google and Tik Tok display their job listings, where similar roles would have their differences specified in the role name.

Google

image.png

Tik Tok

image.png

Secondly, tags are labels that a user can associate with an entry. They are just a convenient way that the user can use to identify certain keywords with the entry.

Taking into account the two points above, our team feels that the argument for using tags as a factor in differentiating internships is not a strong one. Instead, differences between entries should be highlighted using the essential fields. Thus, we stick by our original implementation of detecting duplicate internships, and hence would not classify this as a bug. Nevertheless, thanks for your time!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Thanks for your response! While the team has raised valid points, it seems that there may be contradictions within your argument. > **most if not all companies** specify the differences between 2 internships in the name of the role Here you have correctly pointed out that while most companies may differentiate internship positions in their job titles, there are some exceptions to this rule. As an example, I have provided an image from AutoDesk's career portal to illustrate this point. The two positions have the **same role name** but with **different job IDs**, moreover, the descriptions for both jobs are different. ![image.png](https://raw.githubusercontent.com/Jnjy/pe/main/files/1444a147-33fe-4e39-b89d-337feeafd9e9.png) - [Software Engineer #1](https://autodesk.wd1.myworkdayjobs.com/en-US/uni/job/Singapore-SGP/Intern--Software-Development-Engineer--PSET-CPD-IDL-_23WD67754?q=software%20engineer) - [Software Engineer #2](https://autodesk.wd1.myworkdayjobs.com/en-US/uni/job/Singapore-SGP/Intern--Software-Development-Engineer--PSET-CPD-IDL--_23WD67760?q=software%20engineer) ### Problem 1 In this context, it's worth noting that although the job title appears to be the same for both internship positions, they are actually differentiated by their unique job IDs. This means that if a user were to add the role using the displayed job title and tag the ID instead, `InternBuddy` may flag the later entry as duplicate. However, both of these internship positions can be applied to by the same candidate. A scenario that will result in incorrect duplicate check will be if I have applied for these two roles and wish to track them individually. To be more precise, the below activity will fail: 1. `add n/Autodesk r/Intern, Software Development Engineer s/Applied d/2023-04-20 t/23WD67754` 2. `add n/Autodesk r/Intern, Software Development Engineer s/Applied d/2023-04-20 t/23WD67760` ### Problem 2 > Let us consider how Google and Tik Tok display their job listings Now, let's examine the case of Google and how the company display its job listings. It's evident that the job titles used in the internship openings shown exceed the character limit (`50` characters maximum) set by the team. For convenience in viewing, I have attached the name and constraint set by the team on the number of characters here below: - Senior Software Engineer, Google Cloud Unified Fulfillment Optimization [71 characters] - Senior Software Engineer, Embedded Systems/Firmware, Platforms Infrastructure Engineering [89 characters] ![image.png](https://raw.githubusercontent.com/Jnjy/pe/main/files/de6c7bf7-5611-439c-840c-8cf031e5b40a.png) This makes it difficult to differentiate between roles based solely on their name as they are unable to insert an internship with such a long role name. Consequently, tagging with specific roles becomes necessary, but this raises the issue of differentiating between two identical roles with distinct job scopes. ### Disagreeing Response Type I have tagged this as `severity.low` as it does not affect normal usage but such scenario where users have to result in using tags to distinguish same role will happen. Therefore, I disagree with the team's decision in rejecting this flaw.