search

Joelius300 / ChartJSBlazor

This library is a modification of the awesome ChartJs.Blazor library by mariusmuntean. It's supposed to add more functionality to the LineChart and generally make the library more complete.
Other
40 stars 6 forks source link

Adjusted @functions to @code. #59

Closed SeppPenner closed 5 years ago

SeppPenner commented 5 years ago

The call to @functions should be changed to @code following https://devblogs.microsoft.com/aspnet/asp-net-core-and-blazor-updates-in-net-core-3-0-preview-6/

Rename @functions to @code

Joelius300 commented 5 years ago

Since this needed to be done for more than just this one chart, I added it in https://github.com/Joelius300/ChartJSBlazor/pull/60. I think this is acceptable since it's a change that is connected to updating the packages (although we could've done it earlier) and also because it only affects the samples.

SeppPenner commented 5 years ago

Yes, that's okay.

Joelius300 commented 5 years ago

Very sorry, I missed it in the readme as well.. I'll do that quickly, you don't need to do anything @SeppPenner :)

SeppPenner commented 5 years ago

Haha okay. This always happens to me as well...