search

Joelius300 / ChartJSBlazor

This library is a modification of the awesome ChartJs.Blazor library by mariusmuntean. It's supposed to add more functionality to the LineChart and generally make the library more complete.
Other
40 stars 6 forks source link

Added polar area example. #80

Closed SeppPenner closed 5 years ago

SeppPenner commented 5 years ago

I have not had the possibility to check it yet (cannot run it from this PC) but I think I can assume that you checked that it works (e.g. clicking the labels, animation etc), right?

Yes, it's tested.

By the way, I think you should try to be consistent with the use of AddRange. First you use an array and then a list. Just use array in both, it's also less expensive :)

That was a mistake I guess. I will correct this in the other examples as well, because there it's the same... (I just copied the pie chart example and adjusted it 😄).

You're right. I was searching for another icon that fits, but the bar chart as default is a good idea. And yes, the line chart should use the graph icon. Makes more sense.

SeppPenner commented 5 years ago

It's done :)

Joelius300 commented 5 years ago

Looks good. Will be merged once I get to test it :)

Joelius300 commented 5 years ago

I pushed a commit to use new double[] { 4, 5, 6, 7 } instead of new[] { 4.0, 5.0, 6.0 7.0 } because I like it more this way and as far as I'm concerned it's a bit more 'correct'. I will merge this now.