Updating readme, knownissues link and clientside blazor

Joelius300 / ChartJSBlazor

This library is a modification of the awesome ChartJs.Blazor library by mariusmuntean. It's supposed to add more functionality to the LineChart and generally make the library more complete.

Other

40 stars 6 forks source link

Updating readme, knownissues link and clientside blazor #95

Closed patrickhacens closed 5 years ago

patrickhacens commented 5 years ago

upading read me with info from issue #93

SeppPenner commented 5 years ago

Looks good for me. Some small changes from my side:

I would close all sentences with a dot
Describe what PROBLEMATIC_COMPONENT stands for and provide an example, e.g. "PROBLEMATIC_COMPONENT here means a specific chart component like ChartJsLineChart"
"For more information, check out our known issues page" (With the link of course as you already have it)

Before you change something here, please wait for @Joelius300 remarks, too. He might have some more ideas.

And thank you for the pull request. I wanted to do that but didn't have the time yet :D

Joelius300 commented 5 years ago

I approve the comments of @SeppPenner. I can only emphasize that the example for the ReferenceConverter stuff has to be very clear.

SeppPenner commented 5 years ago

@Joelius300 I integrated this into https://github.com/Joelius300/ChartJSBlazor/pull/98 (Because both are changes in the readme) to get this done.

Joelius300 commented 5 years ago

Since there were a few changes for the readme that could be done together, this pull request is now unnecessary since your work has been reused in https://github.com/Joelius300/ChartJSBlazor/pull/98 :)