search

Joelius300 / ChartJSBlazor

This library is a modification of the awesome ChartJs.Blazor library by mariusmuntean. It's supposed to add more functionality to the LineChart and generally make the library more complete.
Other
40 stars 6 forks source link

Updated readme: NetCore and VS information, added disclaimer for the UncaughtReference error. #98

Closed SeppPenner closed 4 years ago

SeppPenner commented 4 years ago

Fixes https://github.com/Joelius300/ChartJSBlazor/issues/94, fixes https://github.com/Joelius300/ChartJSBlazor/issues/93, makes https://github.com/Joelius300/ChartJSBlazor/pull/95 redundant.

This pull request updates the information regarding requirements for Visual Studio and .NetCore and adds additional information on two commonly known issues: The Chart not drawn on client-side blazor in .netcore 3.0 from https://github.com/Joelius300/ChartJSBlazor/issues/93 and the Uncaught reference error from https://github.com/Joelius300/ChartJSBlazor/issues/94.

Joelius300 commented 4 years ago

What do we want to do about the prerequisites? For this repo you don't need the preview for Visual Studio since we don't have client-side blazor in it. For the original repo you will need the preview AND you'll need .NET Core 3 preview 9 as well since client-side blazor is not available in .NET Core 3.0.

I think we should adjust it to how it's currently (.NET Core 3.0 and Visual Studio 2019 16.3) but keep the other things I said in mind for the original repo.

Joelius300 commented 4 years ago

Do you approve these changes to your PR @SeppPenner?

SeppPenner commented 4 years ago

I think we should adjust it to how it's currently (.NET Core 3.0 and Visual Studio 2019 16.3) but keep the other things I said in mind for the original repo.

Yeah, that's a good idea.

Joelius300 commented 4 years ago

I guess that's an approval :) I'll merge it.

Joelius300 commented 4 years ago

The commit history of this PR is pretty bad for some reason. Maybe we should've organized it first but since it was squashed it's not a problem in master. I will leave it like this.

SeppPenner commented 4 years ago

The commit history of this PR is pretty bad for some reason.

I have seen that, but I have actually no idea why...