search

JohnDMcMaster / open-tl866

Open Programming Firmware for the TL866A Programmer.
BSD 2-Clause "Simplified" License
131 stars 22 forks source link

Pete/flip bitorder #90

Closed pdietl closed 2 years ago

JohnDMcMaster commented 2 years ago

Request small change in incorrect help message, otherwise LGTM. Thanks!

JohnDMcMaster commented 2 years ago

Actually: can you also do a sweep on the python code? I don't see any changes there and I imagine this will break a lot

pdietl commented 2 years ago

Why do you think it will break a lot?

JohnDMcMaster commented 2 years ago

The bit ordering was changed. Therefore the API will be broken. Take a look at this for example

https://github.com/JohnDMcMaster/open-tl866/blob/master/py/util/read_rom.py

In particular I think this is the line that must be changed to match the C change:

https://github.com/JohnDMcMaster/open-tl866/blob/master/py/otl866/aclient.py#L246

pdietl commented 2 years ago

I believe I addressed all the issues @JohnDMcMaster

JohnDMcMaster commented 2 years ago

LGTM! This is a breaking API change so I'll also follow up with a note to the readme