search

JoinMarket-Org / joinmarket-clientserver

Bitcoin CoinJoin implementation with incentive structure to convince people to take part
GNU General Public License v3.0
731 stars 179 forks source link

Using maximum coinjoin fee limits per maker of 0.1000%, how can I reduce this and impacts does the reduction have on the coinjoin ? #765

Closed scottcarter2020 closed 3 years ago

scottcarter2020 commented 3 years ago

Hello,

Every time I tumble my coins, I get this message (Using maximum coinjoin fee limits per maker of 0.1000%, 0.######### BTC (########## sat)).

How can I use (average) fee limits or even (minimum) ones and how does this impact the tumbling of the coins ?

undeath commented 3 years ago

There's a misunderstanding about the content. All this says is that there is an upper bound (=maximum fee limit) to the fees you are going to pay a maker. Those limits are configurable.

scottcarter2020 commented 3 years ago

@undeath Thank you for your reply, undeath.

@AdamISZ Could you please Adam tell us your opinion and what do you think about @undeath reply ?

AdamISZ commented 3 years ago

I'm not sure why I didn't answer this before. Yes I agree with undeath's reply. Did you see the comments to the configuration vars?:

https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/8718ce1b47f10425c812a3977cbf4448020031a0/jmclient/jmclient/configure.py#L236-L246

The idea behind these settings is: we want to have a pricing mechanism, but we don't want to be so sensitive to price that we only pick the cheapest, since that would allow a snooper to try to always take the liquidity with a zero price, hence we choose randomly under a maximum fee that the taker considers acceptable. But you have to set both rel and abs prices because makers can use either.

AdamISZ commented 3 years ago

I'm going to proactively close this, but do reopen if something in the above is unclear.