search

JonZeolla / jzeolla-metron-bro-plugin-kafka

A Bro log writer plugin that sends logging output to Kafka.
Apache License 2.0
3 stars 4 forks source link

Add ability to format JSON timestamps #1

Closed dcode closed 6 years ago

dcode commented 6 years ago

I added the ability to format timestamps using the same convention as the ASCII writer. It still defaults to the JSON::TS_EPOCH. When doing JSON output, I have better luck across myriad of time parsers to use the ISO8601 format. Namely, I've run into parsers that otherwise won't preserve the microsecond precision of the timestamp.

I also changed the behavior of logs_to_send to send all logs by default, if none are specified.

JonZeolla commented 6 years ago

Hi @dcode, thanks for the contribution. After a brief review that looks really good. This repo is actually in the process of migrating to https://github.com/apache/metron-bro-plugin-kafka/ (slowly, and waiting on me). When it gets there, we will definitely be open to accepting PRs, but we will want it to comply with our Development Guidelines. Thanks to you, I'm going try to prioritize that migration and get it done asap. I will report back here when it's ready to go. Thanks again

JonZeolla commented 6 years ago

We have finally completed the migration to the new repo and are finalizing our 0.1 release of this package. Would you mind closing this PR, merging in master of the new upstream, opening a JIRA on this, and then opening a new PR against the apache repo that links to the JIRA? More details about the merge requirements are available here.

Also, can you describe how you tested this? Two prior testing plans that you can steal from if you'd like are here and here. Luckily this one isn't that complicated and should be fairly straightforward to validate. Thanks for the great contribution!