Closed benmccann closed 3 months ago
Latest commit: ccb28bf5d0bea42716928b31989cf1762a581892
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.69%. Comparing base (
31c14f2
) to head (ccb28bf
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@benmccann I can't attest to the original issue #659 as reported, but I can report that this resolves a similar issue I was seeing using npm with vite-imagetools
7.0.2 in my package.json
devDependencies
, that appears to have been due to sharp
being included in devDependencies
vs. dependencies
(fixed at 57e070e)
> vue-tsc --noEmit && vite build --mode development
failed to load config from /Users/tjohns/Src/epic-roadtrip-planner-webapp/vite.config.ts
error during build:
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'sharp' imported from /Users/tjohns/Src/epic-roadtrip-planner-webapp/node_modules/vite-imagetools/dist/index.js
at packageResolve (node:internal/modules/esm/resolve:853:9)
at moduleResolve (node:internal/modules/esm/resolve:910:20)
at defaultResolve (node:internal/modules/esm/resolve:1130:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:396:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:365:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
at link (node:internal/modules/esm/module_job:84:36)
> vue-tsc --noEmit && vite build --mode development
...
✓ built in 8.42s
Thanks for the fix, and I appreciate imagetools
and the work you folks are doing here.
closes https://github.com/JonasKruckenberg/imagetools/issues/659