JonasKruckenberg / imagetools

Load and transform images using a toolbox :toolbox: of custom import directives!
MIT License
954 stars 59 forks source link

fix: remove legacy import assertion unsupported by Node v22 #754

Closed geigerzaehler closed 3 days ago

geigerzaehler commented 1 month ago

I wasn’t able to build the project using Node v22 because it used the legacy import assertion syntax. Support for this was removed from Node. To fix this, I’m reading package.json as to not rely on JSON module support which may be unavailable on older Node versions (?).

I’m also fixing the Github workflows so that they actually run against different Node versions and we can discover this in the future.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 0436e063e15389a4904cc0864fe71394e6e88601

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

benmccann commented 3 days ago

ah. apparently assert is becoming with: https://github.com/nodejs/node/issues/51622