JonasNilson / idle_master_extended

🃏 Get your Steam Trading Cards the Fast Way (Fast Mode Extension 🚀)
GNU General Public License v2.0
2.81k stars 182 forks source link

feat: Final? implementation (with some local strings) of the Quick Login #486

Open SantiiRepair opened 3 weeks ago

SantiiRepair commented 3 weeks ago

This is a temporary or permanent solution, I don't know what you think about it, look at the code, it basically gets the cookies in a temporary browser session, what the user would do in the old days but automated.

I would show you a working video of the upgrade but I would risk my data being leaked, you know...

image

JonasNilson commented 2 weeks ago

I have looked at the code and from what I can tell it looks quite good. I like the structuring and naming of the classes and methods.

I have not yet tested the functionality fully, besides building and running it.

Some notes from me glancing over the code:

  1. How complicated would it be it be to extend the browser cookie support to Firefox and Brave, or potentially more browsers?
  2. I have multiple Steam accounts and I'm curious how the scenario would be handled where I am logged in to one account on the Steam client and another one in my browser and if the code could determine if the "wrong" cookie was fetched

Hopefully I'll be able to try it out more soon.

SantiiRepair commented 2 weeks ago

Regarding number 1, perhaps a little for non-Chromium-based browsers. Regarding number 2, the Steam steamLoginSecure cookie contains the profile ID of the current session, so the solution would be to verify that ID with those saved in Steam's configuration files.

JonasNilson commented 2 days ago

I have tested using Edge but the cookie extraction does not seem to work fully. For example:

Now I might be misunderstanding, but the match.Groups[1] should likely be match.Groups[9] in my case so I guess it depends on the user's browser settings and extensions. Maybe there needs to be some check to find steamcommunity.com among the match.Groups because all the cookies I get back are related to Microsoft services (msn.com, bing.com, etc.)