JonnyHaystack / i3-resurrect

Simple solution to saving and restoring i3 workspaces
GNU General Public License v3.0
368 stars 18 forks source link

1.4.5 wheel on PyPI differs from source #125

Open yurikhan opened 2 weeks ago

yurikhan commented 2 weeks ago

Describe the bug

The code in the built distribution file on PyPI differs from that in the source distribution file and the Git tag 1.4.5.

To Reproduce

  1. pipx install i3-resurrect
  2. look in ~/.local/pipx/venvs/i3-resurrect/lib/python3.10/site-packages/i3_resurrect/main.py

Alternatively:

  1. cd /tmp && wget https://files.pythonhosted.org/packages/fe/30/362d39eaf8d0dc1869fb200bcd9141e545bfd17d703c8b3f4fa76bd0fd9c/i3_resurrect-1.4.5-py3-none-any.whl && unzip -d i3_resurrect-1.4.5-py3-none-any i3_resurrect-1.4.5-py3-none-any.whl
  2. look in /tmp/i3_resurrect-1.4.5-py3-none-any/i3_resurrect/main.py

Expected behavior

Code corresponds to main.py at tag 1.4.5; in particular, line 13 reads the directory key from config into a global DEFAULT_DIRECTORY variable which is further used as the default for the -d, --directory option.

Observed behavior

Code corresponds to 1.4.3, except for config.py which matches that of 1.4.5.

System information (please complete the following information):

yurikhan commented 2 weeks ago

Workaround: pipx install --pip-args=--no-binary=i3-resurrect i3-resurrect installs the source distribution which matches the 1.4.5 tag.

JonnyHaystack commented 1 week ago

Hmm not sure how that could've happened but it's been quite a few years. I should add a GitHub Actions pipeline for releases anyway.