search

JonnyOThan / TweakScale

Forked from Gaius Goodspeed's Goodspeed Aerospace Part & TweakScale plugin
Other
3 stars 2 forks source link

Report: not compatible with Kerbal Research & Development #64

Open JonnyOThan opened 7 months ago

JonnyOThan commented 7 months ago

No logs provided.

KRnD seems to have an upgrade system and it would be worth checking out whether TS/R works with it.

JonnyOThan commented 1 month ago

Oh, that's probably why: https://github.com/linuxgurugamer/KRnD/blob/master/GameData/KRnD/PluginData/blacklist.cfg

etmoonshade commented 1 month ago

This one's always been near and dear to my heart since I played KRnD in its original version and was one of the ones to find the original TweakScale combatibility.

For more context than just "it's blacklisted" (which it very much should be in its current state): Based on what I recall (and re-read on the KRnD forum thread at https://forum.kerbalspaceprogram.com/topic/191014-1x-19x-110x-kerbal-research-development/), there were some design decisions originally made for KRnD that make it fundamentally incompatible with pretty much anything that tweaks a part at runtime, e.g. Tweakscale, any fuel switch mods (B9, IFS,) etc. I started at least one discussion on it on page 5, but there's been a couple of times the question has been asked.

The result is that part values end up inconsistent - sometimes the part stats scale properly, sometimes it applies incorrect values, sometimes it just crashes and burns.

LGG stated in the thread that he didn't want to put the work in to fix it since it'd apparently be a fairly major overhaul, but he'd probably accept a PR if someone were willing to put in the work.

To be clear, I am not (unfortunately) someone here - I can conceptualize a fix from my limited understanding of what's going on under the hood, but I wouldn't be able to pull it off. As the saying goes - "Those who can, do; those who can't, write feature requests." 😁