J4 Helix 3 Php8 Gives Error: array_replace(): Argument #2 () Must Be Of Type Array, String Given - Githubissues

JoomShaper / Helix3

46 stars 37 forks source link

J4 Helix 3 Php8 Gives Error: array_replace(): Argument #2 () Must Be Of Type Array, String Given #111

Open Orgoth opened 2 years ago

Orgoth commented 2 years ago

Bug description

helix3.php uses wrong arguments for addStyleSheet() in Line 642 and 648.

https://github.com/JoomShaper/Helix3/blob/e4b01f37d2f2f09ed507b54a0bcf1e91ef68226b/plugins/system/helix3/core/helix3.php#L642 https://github.com/JoomShaper/Helix3/blob/e4b01f37d2f2f09ed507b54a0bcf1e91ef68226b/plugins/system/helix3/core/helix3.php#L648

With PHP7.x and Joomla3 this does not impact anything, but if the user upgrades to Joomla4 and PHP8 he will get a error message.

Steps to reproduce

setup a server instance with php8.x
setup a new joomla4 instance
install helix 3
set helix3 as default
check the frontpage

Expected behavior

No error exception should be thrown.

Screenshots

Screenshot_20220127_151900

Environment

Ubuntu server minimal 20.04 LTS
PHP 8.x
Apache 2.4
Mysql 5.x+
Joomla 4