search

JoomShaper / Helix3

46 stars 37 forks source link

[2.5.1] MenuItem type External Link / URL - Link Rel Attribute is missing #92

Open pepperstreet opened 6 years ago

pepperstreet commented 6 years ago

Hello, I have tested HELIX3, PROTOSTAR, WARP7 MASTER2, FAVOURITE on [b]Joomla 3.8.5[/b] Only [b]HELIX3 2.5.1[/b] does [b]not[/b] output the rel attribute.

I had a quick look into the HTML overrides. Apparently the file is missing the link rel attribute parameter! ../templates/shaper_helix3/html/mod_menu/default_url.php

Related forum topic: https://www.joomshaper.com/forums/create-a-external-link-menu-with-nofollow-attribute

TinoAugustine commented 6 years ago

Thanks, @pepperstreet for adding this here.

pepperstreet commented 6 years ago

No changes in latest Helix3 v2.5.2 ?

TinoAugustine commented 6 years ago

Hope @JoomShaper team will fix this in the next release :(

rifatwahid commented 6 years ago

Hi, Could you please try this: create-a-external-link-menu-with-nofollow-attribute? We will include this on next update.

pepperstreet commented 6 years ago

Thanks. But there is still an issue with the output. Values seem to work, but not empty/None. It outputs an orphaned rel

test_linkrelattribute_nofollow_none

Your file applies to megamenu… please, remember to fix the HTML override as well! ../templates/shaper_helix3/html/mod_menu/default_url.php It does not include the parameter.

rifatwahid commented 6 years ago

Hi, Here is the fix: https://github.com/JoomShaper/Helix3/commit/eecff31236a4fde5e69472061d4b1cc4259e9df1