search

JordanSantiagoYT / FNF-JS-Engine

JS Engine is basically Psych Engine but with (almost) no botplay lag and NEW features!
Apache License 2.0
48 stars 33 forks source link

Custom notes offset strangely #662

Closed Niko-The-Fluffy closed 1 month ago

Niko-The-Fluffy commented 1 month ago

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!

The custom notetypes are offset slightly, to the left and up a bit. this also causes strange hitbox bugs, rendering some of our songs impossible without botplay, and is just generally annoying. image

Command Prompt/Terminal/Crash logs (if existing)

No response

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.

The bug happens naturally, as seen in the attached image. image

Are you modding a build from source or with Lua?

Lua

What is your build target?

Windows

Did you edit anything in this build? If so, mention or summarize your changes.

Creating an entire FNF mod, the only thing broken is the note offsets.

If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?

None

Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.

Yes

Niko-The-Fluffy commented 1 month ago

I didn't mean to put the image twice-

moxie-coder commented 1 month ago

that could just be from the effects, or from your notes xml offsets

PatoFlamejanteTV commented 1 month ago

It is a modified arrow (custom skin/note) or it's a normal arrow?

Niko-The-Fluffy commented 1 month ago

that could just be from the effects, or from your notes xml offsets

nope, it worked perfectly fine before we ported the mod over to JS engine

Niko-The-Fluffy commented 1 month ago

It is a modified arrow (custom skin/note) or it's a normal arrow?

custom_notetype used for this, happens with other custom notetypes as well.

JordanSantiagoYT commented 1 month ago

image it could be because of this snippet of code, let me check

PatoFlamejanteTV commented 1 month ago

It is a modified arrow (custom skin/note) or it's a normal arrow?

custom_notetype used for this, happens with other custom notetypes as well.

Can you send a random code from any custom_notes arrow? It may be a problem with the (softcoded) code.

JordanSantiagoYT commented 1 month ago

It is a modified arrow (custom skin/note) or it's a normal arrow?

custom_notetype used for this, happens with other custom notetypes as well.

Can you send a random code from any custom_notes arrow? It may be a problem with the (softcoded) code.

well actually, this seems to also happen with the Phone Note notetype when i use it. so it could be because of a snippet of code

JordanSantiagoYT commented 1 month ago

image well it fixed normal notes, not so sure about the Sustain Notes though

Niko-The-Fluffy commented 1 month ago

eh, i don't really plan on using sustain custom notes for the mod, i was mainly worried about the actual notes themselves