Open JorelAli opened 1 year ago
I notice that comment is from a Paper PR. If this change was applied, would the CommandAPI still work on Spigot? If not, I suppose we would just need to migrate calls to getBrigadierDispatcher
over to PaperImplementations
.
Also, does this change apply to Paper right now, or only after that PR is merged?
I notice that comment is from a Paper PR. If this change was applied, would the CommandAPI still work on Spigot? If not, I suppose we would just need to migrate calls to
getBrigadierDispatcher
over toPaperImplementations
.Also, does this change apply to Paper right now, or only after that PR is merged?
Yes, this will still work on Spigot. The MinecraftServer#getCommands
method exists in Spigot and has always existed since 1.13. There isn't any particular reason why the CommandAPI should not be using this method, other than the fact it hasn't been tested and testing will be required to ensure it's a viable solution (i.e. make sure everything works as it should!)
Description
As per this comment:
Expected code
Replace the use of
MINECRAFT_SERVER.vanillaCommandDispatcher
in NMS implementations ofNMS#getBrigadierDispatcher
https://github.com/JorelAli/CommandAPI/blob/2efd3a3ffdee797ab8b2a4b12784c9e5741d197a/commandapi-nms/commandapi-1.19.3/src/main/java/dev/jorel/commandapi/nms/NMS_1_19_3_R2.java#L395-L398with
MINECRAFT_SERVER.getCommands()
:Extra details
No response