search

JorgeGIlG / MTF_Estimator

Robust ESF, PSF, FWHM & MTF estimation from low quality images.
GNU General Public License v3.0
54 stars 8 forks source link

MTF estimator #15

Closed Walaahij closed 1 year ago

Walaahij commented 1 year ago

when I activate the MTF estimator, I don't get the final graph that includes MTF and ESF graph like in the gif in the git repository of the MTF_Estimator. do you know why?

JorgeGIlG commented 1 year ago

Can you provide more details?

Walaahij commented 1 year ago

I want to use the MTF Estimator I downloaded the git rapisotory amd added it to the plugins in QGIS but it says that :" This plugin is broken, missing metdata file" the QGIS version that I have is QGIS 3.30 is this the reason that I can't use the MTF Estimator? thanks in advance Walaa

מאת: Jorge Gil @.> ‏‏נשלח: יום חמישי 11 מאי 2023 16:03 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

Can you provide more details?

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1543969147, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3SX2AK2S5JDEMUGVY4LXFTPSRANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

JorgeGIlG commented 1 year ago

On GIT there is just the source code. Try using the "Plugins" menu on QGIS. "Manage and install plugins" -> Search "MTF Estimator" -> "Install Plugin". That should work.

Walaahij commented 1 year ago

I tried to add a plugin Repository and I got this ERROR:

Error reading repository: MTF

Server response is 200 OK, but doesn't contain plugin metadata. This is most likely caused by a proxy or a wrong repository URL. You can configure proxy settings in QGIS options.

מאת: Jorge Gil @.> ‏‏נשלח: יום חמישי 11 מאי 2023 16:14 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

On GIT there is just the source code. Try using the "Plugins" menu on QGIS. "Manage and install plugins" -> Search "MTF Estimator" -> "Install Plugin". That should work.

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1543988723, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3STHVQR6Z2C3O5XE3N3XFTQ3NANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

JorgeGIlG commented 1 year ago

Try downloading the latest version of the plugin in zip format from https://plugins.qgis.org/plugins/mtf_estimator/ and then use the "Install from ZIP" option on QGIS. Using this way you won't receive updates.

Walaahij commented 1 year ago

It worked Thank you very much 🙂

מאת: Jorge Gil @.> ‏‏נשלח: יום חמישי 11 מאי 2023 16:31 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

Try downloading the latest version of the plugin in zip format from https://plugins.qgis.org/plugins/mtf_estimator/ and then use the "Install from ZIP" option on QGIS. Using this way you won't receive updates.

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1544017769, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3SSD4MWZGPSAXJHWX2LXFTS3PANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

Walaahij commented 1 year ago

I used it yesterday and it worked perfectly, now it doesn't work I am trying to fix the problem but I don't know what is wrong?

מאת: Jorge Gil @.> ‏‏נשלח: יום חמישי 11 מאי 2023 16:31 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

Try downloading the latest version of the plugin in zip format from https://plugins.qgis.org/plugins/mtf_estimator/ and then use the "Install from ZIP" option on QGIS. Using this way you won't receive updates.

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1544017769, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3SSD4MWZGPSAXJHWX2LXFTS3PANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

Walaahij commented 1 year ago

could you please send me the step by step how to download this pulgin ?

מאת: Jorge Gil @.> ‏‏נשלח: יום חמישי 11 מאי 2023 16:31 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

Try downloading the latest version of the plugin in zip format from https://plugins.qgis.org/plugins/mtf_estimator/ and then use the "Install from ZIP" option on QGIS. Using this way you won't receive updates.

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1544017769, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3SSD4MWZGPSAXJHWX2LXFTS3PANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

JorgeGIlG commented 1 year ago

The current version can be downloaded just by clicking on https://plugins.qgis.org/plugins/mtf_estimator/version/1.2/download/

Walaahij commented 1 year ago

it turns out that this time it is a python problem|: [cid:852ab6d8-4de7-4ad4-869c-6d9712463231] and when I run the mtf_estimator code I get this error: [cid:6d18aae0-550d-42c9-a946-40498539344e]

מאת: Jorge Gil @.> ‏‏נשלח: יום שני 15 מאי 2023 21:33 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

The current version can be downloaded just by clicking on https://plugins.qgis.org/plugins/mtf_estimator/version/1.2/download/

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1548358908, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3SUCZEG4WE6HNDJ4XNLXGJZF5ANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

JorgeGIlG commented 1 year ago

There is an issue with numpy and the python version delivered with QGIS 3.30. I'll fix it and let you know when it is done.

Walaahij commented 1 year ago

thank you

מאת: Jorge Gil @.> ‏‏נשלח: יום שלישי 16 מאי 2023 18:37 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

There is an issue with numpy and the python version delivered with QGIS 3.30. I'll fix it and let you know when it is done.

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1549910854, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3SQKO4K5FQVVOWR3DRTXGONK3ANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

JorgeGIlG commented 1 year ago

The version attached should work for you. Can you please try it out? mtf_estimator-1.2.1.zip

Walaahij commented 1 year ago

I am sorry but I am new in this, and it still didn't work for me it gave me this message: [cid:bc094875-aa11-4bee-bd50-180c19e82b21] what does it mean and how can i fix it?

מאת: Jorge Gil @.> ‏‏נשלח: יום שלישי 16 מאי 2023 20:25 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

The version attached should work for you. Can you please try it out? mtf_estimator-1.2.1.ziphttps://github.com/JorgeGIlG/MTF_Estimator/files/11490402/mtf_estimator-1.2.1.zip

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1550078632, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3SX7XJVDQMN67LU7LZLXGO2BFANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

Walaahij commented 1 year ago

and this message in the python error: [cid:ecb4b4bb-3234-478f-8213-6276d72334b5]

מאת: Walaa Hijazi @.> ‏‏נשלח: יום רביעי 17 מאי 2023 08:30 ‏‏אל: JorgeGIlG/MTF_Estimator @.> ‏‏נושא: Re:‏ [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

I am sorry but I am new in this, and it still didn't work for me it gave me this message: [cid:bc094875-aa11-4bee-bd50-180c19e82b21] what does it mean and how can i fix it?

מאת: Jorge Gil @.> ‏‏נשלח: יום שלישי 16 מאי 2023 20:25 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

The version attached should work for you. Can you please try it out? mtf_estimator-1.2.1.ziphttps://github.com/JorgeGIlG/MTF_Estimator/files/11490402/mtf_estimator-1.2.1.zip

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1550078632, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3SX7XJVDQMN67LU7LZLXGO2BFANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

Walaahij commented 1 year ago

Another question that is related to the MTF calculation, did your calculations was based on a certain article? or where it was based on?

thnaks in advance: Walaa

מאת: Jorge Gil @.> ‏‏נשלח: יום שלישי 16 מאי 2023 20:25 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

The version attached should work for you. Can you please try it out? mtf_estimator-1.2.1.ziphttps://github.com/JorgeGIlG/MTF_Estimator/files/11490402/mtf_estimator-1.2.1.zip

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1550078632, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3SX7XJVDQMN67LU7LZLXGO2BFANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

JorgeGIlG commented 1 year ago

Please try to obtain the stack trace. When the plugin fails QGIS will show you a message like the one attached.

image

Walaahij commented 1 year ago

I don't understand the error what is CRS , and why it gave me this message error:

CRS was undefined: defaulting to project CRS EPSG:4326 - WGS 84

AttributeError: 'NoneType' object has no attribute 'SetProjection'

why in the begining it worked for me but then it stopped working

מאת: Jorge Gil @.> ‏‏נשלח: יום רביעי 17 מאי 2023 11:28 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

Please try to obtain the stack trace. When the plugin fails QGIS will show you a message like the one attached.

[image]https://user-images.githubusercontent.com/67840250/238883432-5fcafc45-d73e-4ddc-94fa-355d94856344.png

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1550974755, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3SQXEBONQAHSBJUNY2DXGSD4NANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

JorgeGIlG commented 1 year ago

CRS is the coordinate reference system of your raster or vector. Is that what the stack trace returned?

Walaahij commented 1 year ago

YES and I don't undersrtand how to activate it he is telling me CRS was undefined why ?

מאת: Jorge Gil @.> ‏‏נשלח: יום רביעי 17 מאי 2023 11:52 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

CRS is the coordinate reference system of your raster or vector. Is that what the stack trace returned?

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1551006776, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3SVCEKSFE36GPADIKELXGSGV5ANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

JorgeGIlG commented 1 year ago

Please provide more details about the images you are working with. Are they projected? What is the projection? What is the CRS? An screenshot would also help.

Walaahij commented 1 year ago

Great question we want to do a validation for a camera that we want to use for taking images of clouds, so we want tocalculate the MTF of the photos, we found some sources of python examples, but your's is the best, because it is acurate we wanted to run your code to an example image [cid:57160847-d5ed-4ac6-af71-7cb8f4301c4d]

the yellow shape is the layer that i generated to calculate the MTF, at first it worked for me but then i had issues. but I got great results.

another thing could you please send me an email a work email much better for me

IMPORTANT NOTE: We want to know on what scientific articles your calculations was based on? so if everything worked for us we want to mention that we used your code

Walaa

מאת: Jorge Gil @.> ‏‏נשלח: יום רביעי 17 מאי 2023 13:32 ‏‏אל: JorgeGIlG/MTF_Estimator @.> עותק: Walaa Hijazi @.>; Author @.> ‏‏נושא: Re: [JorgeGIlG/MTF_Estimator] MTF estimator (Issue #15)

Please provide more details about the images you are working with. Are they projected? What is the projection? What is the CRS? An screenshot would also help.

— Reply to this email directly, view it on GitHubhttps://github.com/JorgeGIlG/MTF_Estimator/issues/15#issuecomment-1551146649, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZKS3STEDTE4IFDBIC6VI3LXGSSNXANCNFSM6AAAAAAX4XYOZQ. You are receiving this because you authored the thread.Message ID: @.***>

External e-mail, be judicious when opening attachments or links

JorgeGIlG commented 1 year ago

Did you attach anything in your previous message? I can't see it. I haven't published anything about this algorithm. To provide attribution please use the following page as reference: https://jorgegilg.github.io/MTF_Estimator/Algorithm_Description.html