search

JosefNemec / LiteDbExplorer

Viewer and editor for https://github.com/mbdavid/LiteDB databases.
MIT License
218 stars 104 forks source link

upgrade litedb to 4.0.0 #22

Closed malmas18 closed 6 years ago

malmas18 commented 6 years ago

updated the litedb nuget package to 4.0.0 and removed all usages of Transactions. DocumentViewer works again after this.

JosefNemec commented 6 years ago

You can't just remove transactions, they are there for a reason. This will break rollback of values in case you are editing nested documents and you choose to cancel editing.

malmas18 commented 6 years ago

The API's for transactions were removed by LiteDB in 4.0.0, hence the removal. With my testing of the application, the OK and Cancel buttons in the parent and nested documents still work. If you don't believe that is the case, can you spec out what you expect the behavior of the OK and Cancel buttons in the parent and nested forms?

disshishkov commented 6 years ago

Can be this merged and released at least as temporal build just to support v4 with a note that cancel functionality will not work correctly?