search

JoshuaRaybould / SSH

0 stars 0 forks source link

Setting up database #38

Open JoshuaRaybould opened 1 week ago

JoshuaRaybould commented 1 week ago

I have put the necessary database tables in the databaseSSH.sql file so these can automatically be loaded in when the postgres docker contain is ran.

Next I plan to add a piece of test data to each of these and test that we can properly get data back, hopefully adding this to our CI.

benjoseph05 commented 1 week ago

sounds good

JoshuaRaybould commented 1 week ago

Whilst the main portion of the database is set up and has been confirmed to work, after we further discussed it became apparent we may want to remove some tables, so I'll leave this issue open until we've fully decided and completed this part.

JoshuaRaybould commented 6 days ago

I think since we are planning to just hardcode recipes elsewhere we could do with removing the recipes table, I think there may be other stuff we want to clean up slightly so someone can do that as a bigger thing later on, in a dedicated branch, unless @benjoseph05 removes it when he is hardcoding the recipes in java. After this, this issue can be closed.

benjoseph05 commented 6 hours ago

With the JSON recipe file, we can remove the recipe csv file yes?