search

Jouca / GDUtils-Geode

A Geometry Dash mod adding more tools on the game (Online notifications, level URL, epic UI redesigns, auto-song mute, games fixes & more)
GNU General Public License v3.0
15 stars 7 forks source link

make the pings to https://gdutils.clarifygdps.com optional #11

Closed TheBearodactyl closed 7 months ago

TheBearodactyl commented 7 months ago

btw, i reversed the actions of the first 2 commits with the fourth one, the code is still there.

FireMario211 commented 7 months ago

This does more than just allow that option, there's no need to change all of these files besides only main.cpp if it's not required. Plus the setting is a bit vague on exactly what it does, as some users might not know what "Enable Pinging" does (It toggles whether or not users can receive notifications but the setting doesn't explain that). Also it changes some of the strings, which is that really the point of this PR?

Anyways, I can implement this feature, though unsure if I can merge this PR.

TheBearodactyl commented 7 months ago

This does more than just allow that option, there's no need to change all of these files besides only main.cpp if it's not required. Plus the setting is a bit vague on exactly what it does, as some users might not know what "Enable Pinging" does (It toggles whether or not users can receive notifications but the setting doesn't explain that). Also it changes some of the strings, which is that really the point of this PR?

Anyways, I can implement this feature, though unsure if I can merge this PR.

@FireMario211 the other files were just a result of jetbrains autoformatting the open files on commit, nothing else. Also, I can update the description real quick, just gimme a minute

FireMario211 commented 7 months ago

This has been added in the recent update