Closed nytelytee closed 1 month ago
Side note: whoops this part doesn't actually do what I wanted it to do lol, I just sent the api requests in a browser and looked at the output.
- if (json.dump() == "[]") { //idk how to check size, doing .count crashes
- log::info("Level not found in pointercrate.");
+ if (json.contains("code")) {
+ log::info("Level not found in AREDL.");
I did not notice that it didn't work because the list contains all extreme demons. I had to go and add 1 to the level ID to test it, and I did that after I had opened this issue already.
We could add an option to switch to using AREDL, but we aren't going to change this mod to just only use AREDL as there are some inaccuracies
We could add an option to switch to using AREDL, but we aren't going to change this mod to just only use AREDL as there are some inaccuracies
If accuracy is a concern, then legacy levels should be omitted from the mod, as their "placements" on the demon list are severely outdated and don't count harder levels above them that were released after they fell off the list. It also doesn't make sense to consider a list less accurate than the other when it's entirely subjective.
We could add an option to switch to using AREDL, but we aren't going to change this mod to just only use AREDL as there are some inaccuracies
If accuracy is a concern, then legacy levels should be omitted from the mod, as their "placements" on the demon list are severely outdated and don't count harder levels above them that were released after they fell off the list. It also doesn't make sense to consider a list less accurate than the other when it's entirely subjective.
I agree. I wasn't saying that AREDL should not be added. I was more so saying it shouldn't be replaced as some people have opinions on them.
BTW, if you do end up adding an option, AREDL has an option to fetch the entire list at once, it seems, I looked at the Grandpa Demon source code. Not sure if Pointercrate has a similar option or not, but in the case of AREDL at least, maybe it would make more sense to make a single request when the game is first started and then cache the results?
Would be great to have the option to use the All Rated Extreme Demons List instead of the Pointercrate one, in my case mainly because the Grandpa Demon mod uses AREDL to change the difficulty faces, so I would want to be more in line with the difficulty faces it shows me.
This is all I had to do to get it to request to AREDL instead of Pointercrate (obviously the code would be different if an actual option were added, but this is just to demonstrate how the request would look):