search

JuanPotato / Legofy

Make images look as if they are made out of 1x1 LEGO blocks
MIT License
3.16k stars 189 forks source link

Added CONTRIBUTING.md for contributing #91

Closed christoga closed 8 years ago

christoga commented 9 years ago

Added CONTRIBUTING.md for contributing, So people didnt messed up with the project

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling bf023a1 on christoga:master into 61f9f52 on JuanPotato:master.

christoga commented 9 years ago

Yes, you can fix it if you want @nabijaczleweli

nabijaczleweli commented 9 years ago

No, I can't; I ain't got no push access to yer fork

christoga commented 9 years ago

Done @nabijaczleweli

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 4bd0f47 on christoga:master into 61f9f52 on JuanPotato:master.

nabijaczleweli commented 9 years ago

:+1:

JuanPotato commented 9 years ago

I don't really think it is necessary to list all the contributors, just my opinion.

christoga commented 9 years ago

You can remove it if you want to. @JuanPotato You're the owner.

niroyb commented 9 years ago

I agree with @JuanPotato , there is no need to list the contributors in a file since the github contributors page will always be up to date and doesn't have to be maintained.

christoga commented 9 years ago

Ok guys, I added things that you guys want,

The @landscape-bot is checking the commits that I made, Cheers! :smile:

JuanPotato commented 9 years ago

(Merge commits into one)

christoga commented 9 years ago

???

nabijaczleweli commented 9 years ago

!!!

JuanPotato commented 9 years ago

Just found it ironic that this PR doesn't follow the guidelines in the contributing file :laughing: I can add it in without the PR, I want to give you credit, but 7 commits for one file is excessive, and I thought that you should follow one of the guidelines in the file and merge the commits.

nabijaczleweli commented 9 years ago

This PR is just a huge trainwreck, ain't it?

nabijaczleweli commented 9 years ago

It is a huge trainwreck.

JuanPotato commented 8 years ago

I'm sorry, this PR is really a mess, I can make my own contributing.md or you can make a new clean PR @christoga

christoga commented 8 years ago

Thank you.