shutters and mode for set room temperature + errorhandling

[servidge]

Maybe it's useful. My Perl knowledge is limited so that the Code changes doesn't look pretty but previous tests were successful and it works for me. All just tested with the executable max. I just Changed parts of the Perl modules.

The request contains:

• use of <mode> for set room temperature
  • mode input as text or number value: 00 or auto, 01 or manual, 10 or vacation, 11 or boost
  • new environment variable MAX_DEFMODE for Default <mode>
• output of shutters and those values within do_status
• added do_batstatus
• some, more or less error handling

fixed: With every start Shutters and probably Buttons still cause errors like:

Use of uninitialized value $setpoint in bitwise and (&) at /opt/eq3-max-master/bin/../lib/Max.pm line 127, <GEN0> line 8.
Use of uninitialized value $setpoint in bitwise and (&) at /opt/eq3-max-master/bin/../lib/Max.pm line 128, <GEN0> line 8.

They are probably caused by the lines: Lines were in the wrong order

$temp |= !!($setpoint & 0x80) << 8;
$setpoint &= 0x7F;

At the moment i don't have a quick fix for that. Works anyway. fixed.

best regards, Sebastian

Edited the further progress. second Pull request from branch "deb_process_L" and nor my master

[Juerd]

Hi, thanks for taking the time to improve this software and sending in your pull request. Please excuse me for not responding earlier.

I've decided not to merge this PR. There are several aspects that I'm not comfortable with.

I'm not comfortable with:

• Making binary strings ("00", "01", "10", "11") part of an API.
• Commands that are incompatible with previous versions, because that means all users need to update their scripts.
• Supporting unspecific prefixes as names for enumerated values; I wouldn't mind supporting specific abbreviations.
• Duplicating code (in do_status).
• The specific battery status display, as this is redundant with max status which includes BATTERY flags. Maybe if you could explain the use case for a separate overview, that could convince me.
• Commits with only temporary debug prints. Please rebase to squash them out, or just don't commit them.

I have, however, used one of your commits that is an obvious fix, and made a change that should silence a warning that I learned about through your suggestions.

[servidge]

hey, no problem. i also don't always have time and a month is also long for an simple answer. Had written that it might help, even if it was just a little bit but i stated out that i don't have any clue of perl. So i understand the reasons to only take on the helpful part. So no Problem. The do_batstatus only simplified my external query to prevent dying batteries. The further development looks good and keep up the good work!