Next generation packet parser

Jugendhackt / haskell-ricochet

(WIP/Experimental) Ricochet implementation as Haskell Library.

GNU General Public License v3.0

22 stars 0 forks source link

Next generation packet parser #26

Closed sternenseemann closed 9 years ago

sternenseemann commented 9 years ago

Resolves #21.

I would like to have some kind of code review. Don't merge yet, I'll do that

@shak-mar Could you please review my changes and especially if I broke splitPackets? (Also see my message)

froozen commented 9 years ago

I'm not particularily fond of the hardcoded service addresses. Couldn't we just take them from the command line arguments?

photm5 commented 9 years ago

You didn’t break splitPackets, but it only worked with our old understanding of the protocol. We’ll need to replace a maxBounds with maxBounds - 4 somewhere. I think we should use makePacket in splitPackets' too.

photm5 commented 9 years ago

Fixes #17.

sternenseemann commented 9 years ago

Anything else I should include into this Pull Request?

froozen commented 9 years ago

I think it's ready to merge.

sternenseemann commented 9 years ago

Yay!