Jugendhackt / haskell-ricochet

(WIP/Experimental) Ricochet implementation as Haskell Library.
GNU General Public License v3.0
22 stars 0 forks source link

Improve protobuf lenses #45

Closed photm5 closed 8 years ago

photm5 commented 8 years ago

The lenses were broken just a bit, have a look at the commit message for more information on that. In addition, I added d to the Protobuf utils module, which is quite useful:

let r :: Control.Packet = d & channel_result .~ Just
         (d & channel_identifier .~ 0
            & opened .~ True
            & common_error .~ Nothing)

I’m not sure about the name though... It should be a lot shorter than defaultValue, since that’d just be annoying.

froozen commented 8 years ago

Seems good. :+1: