Move UserRestController logic

[vaa25]

Move logic from UserRestController into services and fix old and add new test for this moving

[IgorMaksymov]

@vaa25 i dont see any logic there, that should be moved

[romach]

@AndriyBaibak 1 hour spent

[romach]

@vaa25 do you mean that controller must only invoke services and not to manipulate other objects?

[romach]

@AndriyBaibak 1 hour spent

[romach]

@vaa25 for example in UserRestController we have method

public void deactivateSubscription() {
    User user = userService.getAuthorizedUser();
    userService.deactivateUserSubscription(user);
}

Should we refactor it that it will contain method, for example, userService.deactivateAuthorizedUserSubscription() that will contain User user = userService.getAuthorizedUser(); logic?

[vaa25]

@IgorMaksymov @romach one controller method must have only one service method call. This service method can call another service and other methods. This was discussed earlier by PO or TL, I don't remember who of them exactly.

[romach]

@vaa25 I understood

[romach]

@AndriyBaibak 1 hour spent

[romach]

@AndriyBaibak 30 minutes spent

[romach]

@AndriyBaibak 30 minutes spent