JujaLabs / itevents

Resource to subscribe on it events
Apache License 2.0
7 stars 5 forks source link

#181-exception-when-otp-is-null #193

Closed IgorMaksymov closed 8 years ago

IgorMaksymov commented 8 years ago

Exception is generated, when the one time password is incorrect connect to #181

romach commented 8 years ago
vaa25 commented 8 years ago

@IgorMaksymov you forgot to log exception. video. @AndriyBaibak 10 min

IgorMaksymov commented 8 years ago

@vaa25 is this so important, to log a mistype? @alex-anakin we need to log all of our exceptions?

vaa25 commented 8 years ago

@IgorMaksymov almost PASSED. You can merge your pr after merging master in your branch and checking all ok.

IgorMaksymov commented 8 years ago

@vaa25 there is no conflicts with master, it will merge it without any conflicts.

IgorMaksymov commented 8 years ago

@vaa25 do not merge it!

IgorMaksymov commented 8 years ago

@vaa25 its OK now.

vaa25 commented 8 years ago

@IgorMaksymov create todo at new Date() and refer to #195 . @AndriyBaibak 10 min