Closed IgorMaksymov closed 8 years ago
@IgorMaksymov
@IgorMaksymov
actual
with returned
anywhere in testsP.S. Good work overall
@AndriyBaibak 30min
@vaa25 4: What rules? 6: no, its failing without mocking getEvent. FutureEvent just checks date. I can mock them both, but this is redundant 7: idea was, to enable user unassign after event passed, so its correct to just getEvent(). fixed that in EventService
@IgorMaksymov
@vaa25 4: in sources its called Stubbing EventRestControllerTest refactored, review pls
@IgorMaksymov you must merge assignAuthorizedUserToEvent()
and assignUserToEvent()
methods because assignUserToEvent
isn't used anywhere else.
@romach its private method of assignAuthorizedUserToEvent for more readability of code. @vaa25 do you agree, that this methods should be merged?
@AndriyBaibak 30 minutes spent
connect to #186