Closed IgorMaksymov closed 8 years ago
@IgorMaksymov
userDao
rule has redundant eq
, any
1.2 guestRole
is created two times (DRY)setOtpToUser
shouldn't be public and should be removed from service interface@AndriyBaibak 20 min
@vaa25 make new task for this
@IgorMaksymov branch name 196-permission-error
doesn't match issue name (Fix 403 error when enter admin resources (/admin, /users/*/events) with admin user.
) nor pull request name (#196: fixed ROLE check in security checks
)
@IgorMaksymov I think that we also need security test for /users/*/events
@AndriyBaibak 30 minutes spent
@romach when i was taking this task,i dont knew what exactly is happening, that why different names. http 403 is permission error, when you dont have enough rights.
@romach fixed
@IgorMaksymov you could give the issue name to branch (#196-fix-403-error-when-enter-admin-resources-with-admin
)
@IgorMaksymov you should run build locally before pushing to GitHub to avoid fix-commits
@romach yes, sorry, just woke up
connect to #196