search

JujaLabs / itevents

Resource to subscribe on it events
Apache License 2.0
7 stars 5 forks source link

#187 move user rest controller logic #227

Closed romach closed 3 years ago

romach commented 8 years ago

Move logic from UserRestController into services and fix old and add new test for this moving Connect to #187

vaa25 commented 8 years ago

@romach

  1. FilterWrapper.equals() - redundant comment
  2. TokenWrapper - redundant constructor
  3. UserRestController, UserService, MyBatisEventService, EventService- unused import
  4. JwtTokenService - TokenWrapper is in controller package. Service can't use it. I think this part shouldn't change. Maybe I wrong.
  5. Everywhere. for example getEvent(int eventId) -> getEventById(int eventId). getEvent seems to be with Event as argument, not int
  6. MyBatisUserService. FilterConverter the same as TokenWrapper (4) @AndriyBaibak 30min
romach commented 8 years ago

@vaa25 thank you for review. Errors are fixed.

vaa25 commented 8 years ago

@romach thanks for corrections

  1. I mean every method in whole project. Yes, its not your fault and you may not to do it. 4,6. Wrappers and converters should be in controller package (see #121).