search

JuliaAcademy / DataScience

Data Science in Julia course for JuliaAcademy.com, taught by Huda Nassar
https://juliaacademy.com/p/julia-for-data-science
MIT License
488 stars 256 forks source link

Use of DataFrames.by() in video for 01. Data #28

Closed blongworth closed 3 years ago

blongworth commented 3 years ago

At around 21:20, by(D, :StateName, size) is used to illustrate usefulness of DataFrames. by has been removed from DataFrames, so this should be changed to combine(groupby(D, :StateName), size) instead. Would also be good to remind novices about :.

blongworth commented 3 years ago

Same with join() in the next section. Has been replaced by innerjoin() in the notebook, but not in the video.

logankilpatrick commented 3 years ago

This has been updated. Thanks again!

adenoz commented 2 years ago

Hey @logankilpatrick I just cloned this repo yesterday and it still has the by() section in it. The join() has been updated to innerjoin() though. But when I browse through the actual notebook here on Github, the by() code block doesn't even seem to be there so it looks like it's been removed. And also, by() is still mentioned at the bottom in the Finally section.

logankilpatrick commented 2 years ago

Hey @adenoz, can you open a PR if you're comfortable fixing these issues?

adenoz commented 2 years ago

Let me look into that. That'll be my first PR. I'll look into over next day or two.

adenoz commented 2 years ago

Done @logankilpatrick . I realise I had 'by' in my initial code as I was following along with the lessons so wrote it in. I made minor amendments to the Finally... section. See #41