Closed jpsamaroo closed 2 days ago
Attention: Patch coverage is 47.36842%
with 10 lines
in your changes are missing coverage. Please review.
Project coverage is 81.66%. Comparing base (
934c34d
) to head (0953048
).
Files | Patch % | Lines |
---|---|---|
src/core.jl | 47.36% | 10 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm curious, on my machine I'm noticing that the llvm approach is faster than the atomic_pointermodify approach. Is this expected? Do you plan to continue using this package as Julia begins to provide more atomic operations?
I'm curious, on my machine I'm noticing that the llvm approach is faster than the atomic_pointermodify approach. Is this expected? Do you plan to continue using this package as Julia begins to provide more atomic operations?
That isn't expected... Do you have a MWE?
I'm curious, on my machine I'm noticing that the llvm approach is faster than the atomic_pointermodify approach. Is this expected? Do you plan to continue using this package as Julia begins to provide more atomic operations?
Actually it is expected, this PR got never merged :/
Ah, that's unfortunate! It would be great if Julia had better support for atomic increment. Do we know if anything is planned for future versions?
Do we know if anything is planned for future versions?
I will try to find some time to update the old PR.
Thanks for getting this fixed up and merged! ❤️
Yes, thanks! I'm currently working on parallelizing Finch and this package has been integral to getting the peak performance.
Todo:
modify!
implementation