search

JuliaData / DataAPI.jl

A data-focused namespace for packages to share functions
Other
33 stars 13 forks source link

Deprecate All #28

Closed bkamins closed 3 years ago

bkamins commented 3 years ago

Fixes https://github.com/JuliaData/DataAPI.jl/issues/27

bkamins commented 3 years ago

I left the tests for All for the time being as is (I propose to remove them when we remove All).

bkamins commented 3 years ago

per recommendation of @piever I updated the PR to allow All() as I think it is not a problem to keep it.

bkamins commented 3 years ago

It seems we will not get much feedback here. Given All() is a natural name I would recommend to retain All() but deprecate All(args...).

bkamins commented 3 years ago

@nalimilan - do we go ahead and merge this then?

bkamins commented 3 years ago

Thank you. Will you tag a release?