search

JuliaData / DataAPI.jl

A data-focused namespace for packages to share functions
Other
33 stars 13 forks source link

Add `join` family without default definition #36

Closed iblislin closed 3 years ago

iblislin commented 3 years ago

close https://github.com/JuliaData/Tables.jl/issues/238

Well, I think the default definition isn't trivial to implement, so I just setup the interface functions. I don't restrict the parameter of join key, which is the kwarg on in DataFrames.jl, since the join key is optional in some cases of time series join.

codecov[bot] commented 3 years ago

Codecov Report

Merging #36 (c4d6089) into main (c46688c) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files           1        1           
  Lines          23       23           
=======================================
  Hits           21       21           
  Misses          2        2
Impacted Files Coverage Δ
src/DataAPI.jl 91.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c46688c...c4d6089. Read the comment docs.