search

JuliaDatabases / DBInterface.jl

Database interface definitions for Julia
https://juliadatabases.org/DBInterface.jl/dev/
Other
84 stars 12 forks source link

Why isn't Base.close used? #24

Closed davidanthoff closed 4 years ago

davidanthoff commented 4 years ago

That seems exactly the right function?

quinnj commented 4 years ago

It's safer to make our own interface function here; Base.close has certain semantics and meaning and we may not want to follow or guarantee the same things. We discovered this in Tables.jl w/ relying on getproperty and propertynames; there might be certain types/scenarios where Base.close is already defined and already has a defined behavior and it's awkward to overload now for DBInterface.

Requiring our own DBInterface.close! lets us avoid any weirdness in all of that.