Closed JanJereczek closed 7 months ago
Attention: 69 lines
in your changes are missing coverage. Please review.
Comparison is base (
971564b
) 41.69% compared to head (3986a3a
) 40.35%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR mainly fixes the tests and docs that broke after the introduction of passing
indicators = nothing
(#65).Majors:
nothing
as an indicator, the need of complementing anif
-statement insignificant_transitions
was overseen. This is now corrected such that the surrogate is correctly passed to the analysis pipeline regardless of the case.full_analysis.jl
needs@test count(flags) == 2
since both indicators are positive at the transition.tail
to be of the same size asindicators
andchange_metrics
too. This would be more consistent and easier to maintain. So far, I applied this to the surrogate analysis. If you agree, we can make the same change across all types of significance analysis.Minors:
warnonly = true
since some referencing were not found. I tried to solve this, which only partially succeeded (I don't understand why the ref to e.g.PrecomputedLowfreqPowerSpectrum
is not found).mean
andvar
?docs/make.jl
, I simplified loading of example files. Before that we were loading by reading the directory, looping over it and then permute the vector to have the desired order. This is actually simpler to just write manually.difference_of_maxes
tosrc/
for potential future use.