JuliaDynamics / TransitionsInTimeseries.jl

Transition Indicators / Early Warning Signals / Regime Shifts / Change Point Detection
MIT License
18 stars 5 forks source link

Extend tests #75

Closed JanJereczek closed 6 months ago

JanJereczek commented 6 months ago

This PR ignores the files that are irrelevant for code coverage and adds new tests for:

For these tests to pass, minor changes have been made:

Finally, I added a few TODO flags and will open corresponding issues :)

codecov-commenter commented 6 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b1d3387) 36.42% compared to head (7be5c96) 83.94%.

Files Patch % Lines
src/change_metrics/slope.jl 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #75 +/- ## =========================================== + Coverage 36.42% 83.94% +47.51% =========================================== Files 18 15 -3 Lines 442 355 -87 =========================================== + Hits 161 298 +137 + Misses 281 57 -224 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Datseris commented 6 months ago
  • include ComplexityMeasure.jl in Project.toml, which is needed for permutation_entropy. I even reexport it, since many functions of this software are usable as metrics for TransitionsInTimeseries.jl.

Let's remove permutation_entropy from the source code and remove the export and remove the dependency. The Logistic map example already shows how to use ComplexityMeasures.jl to compute the permutation entropy.

JanJereczek commented 6 months ago

I agree! It's done and ready for merge :)

Datseris commented 6 months ago

did you remove it also from the @docs block?