Closed JanJereczek closed 6 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
b1d3387
) 36.42% compared to head (7be5c96
) 83.94%.
Files | Patch % | Lines |
---|---|---|
src/change_metrics/slope.jl | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
- include ComplexityMeasure.jl in Project.toml, which is needed for
permutation_entropy
. I even reexport it, since many functions of this software are usable as metrics for TransitionsInTimeseries.jl.
Let's remove permutation_entropy
from the source code and remove the export and remove the dependency. The Logistic map example already shows how to use ComplexityMeasures.jl to compute the permutation entropy.
I agree! It's done and ready for merge :)
did you remove it also from the @docs
block?
This PR ignores the files that are irrelevant for code coverage and adds new tests for:
kolmogorov_smirnov
andpermutation_entropy
src/significance/basic_stat_significance.jl
RidgeRegressionSlope
(previous version was broken and more intricate)SegmentedWindowConfig
timeseries.jl
were included in the test suite. These functions are not used so far but they will be as soon as we deal with unevenly sampled timeseries!For these tests to pass, minor changes have been made:
permutation_entropy
. I even reexport it, since many functions of this software are usable as metrics for TransitionsInTimeseries.jl.nameof(metric::RidgeRegressionSlope)
. This fixes the display ofIndicatorsChangeResults
.Finally, I added a few TODO flags and will open corresponding issues :)