Minors changes for JOSS paper

JuliaDynamics / TransitionsInTimeseries.jl

Transition Indicators / Early Warning Signals / Regime Shifts / Change Point Detection

MIT License

18 stars 5 forks source link

Minors changes for JOSS paper #76

Closed JanJereczek closed 5 months ago

JanJereczek commented 6 months ago

This PR includes following minor changes:

My second affiliation has been removed
/paper has been excluded from codecov, which should largely address #64
The abstracts have been removed from paper.bib
The url link for the documentation in paper.md has been fixed

Datseris commented 6 months ago

it is a waste of computational resources to constantly build the PDF of the paper in every single PR. Let's please remove the draft-pdf workflow once you have managed to build the paper once.

JanJereczek commented 6 months ago

Yes, I think we already agreed on removing the pdf build action as soon as the paper is published!

JanJereczek commented 6 months ago

Documentation is not built properly because of a change in the interplay between trajectory and obtain_state in DynamicalSystemsBase.jl (used in logisitc example of the docs).

Datseris commented 6 months ago

Fixed in https://github.com/JuliaDynamics/DynamicalSystemsBase.jl/pull/201

@JanJereczek , some advice for the future. If you have found an error, paste it. Don't just say "this error happened", copy the error message and paste it. Or alternatively copy the CI log line that has the error if you don't want to paste the entire thing. Let's not duplicate the effort to find the bug, which in some cases like now is trivial, but in general is non zero.

JanJereczek commented 5 months ago

Thanks for fixing it @Datseris. The PR should be ready to merge! You are right, I will include the error messages in future :)