JuliaDynamics / TransitionsInTimeseries.jl

Transition Indicators / Early Warning Signals / Regime Shifts / Change Point Detection
MIT License
18 stars 5 forks source link

Benchmarks in the paper should be done using benchmarking packages #80

Closed felixcremer closed 3 months ago

felixcremer commented 3 months ago

Why are you using the now() - prevtime method for benchmarking and are not using BenchmarkTools and timeit in python?

In the current setup of the julia benchmarks the first compilation time is included in the first run.

https://github.com/openjournals/joss-reviews/issues/6464

Datseris commented 3 months ago

oh yeah, that's bad. That's really bad.