search

JuliaGaussianProcesses / KernelFunctions.jl

Julia package for kernel functions for machine learning
https://juliagaussianprocesses.github.io/KernelFunctions.jl/stable/
MIT License
267 stars 32 forks source link

CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat) #525

Open github-actions[bot] opened 11 months ago

github-actions[bot] commented 11 months ago

This pull request changes the compat entry for the Documenter package from 0.27 to 0.27, 1 for package docs. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.88%. Comparing base (2a6e5e9) to head (90e85b5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #525 +/- ## =========================================== + Coverage 0.42% 90.88% +90.46% =========================================== Files 52 52 Lines 1423 1459 +36 =========================================== + Hits 6 1326 +1320 + Misses 1417 133 -1284 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

theogf commented 11 months ago

It looks like with the new HTML size threshold the docs cannot be built.

willtebbutt commented 11 months ago

It looks like with the new HTML size threshold the docs cannot be built.

Oooo fun. I wonder if this suggests that we should lower the resolution of some of our figures? My understanding of the size threshold is that it's intended to suggest to you that your page is really quite large, and is probably going to cause issues for users. Do you know if I've got that right?

theogf commented 11 months ago

It looks like with the new HTML size threshold the docs cannot be built.

Oooo fun. I wonder if this suggests that we should lower the resolution of some of our figures? My understanding of the size threshold is that it's intended to suggest to you that your page is really quite large, and is probably going to cause issues for users. Do you know if I've got that right?

Yes that's the idea. Of course there's also the solution to raise the threshold...

willtebbutt commented 11 months ago

Ahhh yeah, that might be better. I mean, no one has complained thus far

simsurace commented 10 months ago

Sorry, I deleted the branch by accident.