search

JuliaGaussianProcesses / KernelFunctions.jl

Julia package for kernel functions for machine learning
https://juliagaussianprocesses.github.io/KernelFunctions.jl/stable/
MIT License
267 stars 32 forks source link

Fix Matern AD failures #528

Closed simsurace closed 10 months ago

simsurace commented 11 months ago

Should provide a fix for #526 while the issues revolving around Distances/Zygote/ChainRulesCore are still open.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files Coverage Δ
src/basekernels/matern.jl 100.00% <100.00%> (+76.00%) :arrow_up:

... and 18 files with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!.

simsurace commented 10 months ago

I opened https://github.com/FluxML/Zygote.jl/issues/1464 to track the issue that was unmasked here, as it will be masked once this is merged.

simsurace commented 10 months ago

Bump. I think this should be merged if there are no blockers/change requests.

willtebbutt commented 10 months ago

That being said -- do you know whether it's possible that the performance failures in Transform are at all related to this PR? I can't see how they would be 🤷

simsurace commented 10 months ago

I don't think so. The performance seems to be the number of allocations not being deterministic anymore in Julia 1.9 vs. Julia 1.8, see #530. I haven't had time to look at the detailed profile output to understand where the occasional +1 allocation comes from.