Open simsurace opened 9 months ago
Attention: 9 lines
in your changes are missing coverage. Please review.
Comparison is base (
9a2f7bb
) 72.78% compared to head (f990586
) 66.57%.
Files | Patch % | Lines |
---|---|---|
src/distances/sinus.jl | 0.00% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary A call like
kernelmatrix(PeriodicKernel(), rand(1000))
produces a number of allocations of the same order as the size of the kernel matrix becauseSinus
has a vector parameter and the dispatch hits a path which allocates that for each element of the kernel matrix.Proposed changes We add two specialized methods that use broadcast.
What alternatives have you considered? None.