Closed simsurace closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c97a246
) 90.88% compared to head (a2902be
) 42.19%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm not hugely opposed to this, but I would like to know if you can think of a good use-case for getting an off-diagonal of the kernel matrix. If there's not a good reason to include it in the interface, I'd rather not start having to support it.
Well, it actually does not seem to work for many kernels and mainly because of the calls to Distances.jl.
I don't have a specific use case but simply noted the discrepancy with LinearAlgebra.diag
and that it tends to work for the scalar inputs.
Okay. Shall we just leave this then?
Yeah, let's close this for now.
To test whether
kernelmatrix_diag
gives the same output asdiag ∘ kernelmatrix
for two inputs of different lengths, c.f. question in #552.If tests pass, we could in principle decide to remove the comment in the docstring and make that part of the public API.