jishnub
commented
5 months ago Bisected to 9aa7980358349ee7017fa614525f571ffa92c55d:
9aa7980358349ee7017fa614525f571ffa92c55d is the first bad commit
commit 9aa7980358349ee7017fa614525f571ffa92c55d
Author: Jameson Nash <vtjnash@gmail.com>
Date: Fri Nov 17 13:58:01 2023 -0500
codegen: ensure i1 bool is widened to i8 before storing (#52189)
Teach value_to_pointer to convert primitive types to their stored
representation first, to avoid exposing undef bits later (via memcpy).
Take this opportunity to also generalizes the support for zext Bool to
anywhere inside any struct for changing any bitwidth to a multiple of 8
bytes. This would change a vector like <2 x i4> from occupying i8 to i16
(c.f. LLVM's LangRef), if such an operation were expressible in Julia
today. And take this opportunity to do a bit of code cleanup, now that
codegen is better and using helpers from LLVM.
Fixes #52127
src/cgutils.cpp | 3 --
src/codegen.cpp | 27 ++++--------
src/intrinsics.cpp | 119 ++++++++++++++++++++++++++++++++++++-----------------
test/llvmcall2.jl | 9 ++++
4 files changed, 98 insertions(+), 60 deletions(-)On this commit,
julia> a = zeros(4000,4000); b = rand(size(a)...);
julia> @btime $a[1:end,1:end] .= $b;
61.351 ms (0 allocations: 0 bytes)vs on 045b6f9c88:
julia> @btime $a[1:end,1:end] .= $b;
20.189 ms (0 allocations: 0 bytes)
On v1.10.0
vs on v"1.11.0-DEV.1442" as well as the current master (d54a4550cb)
versioninfo:
Curiously, profiling points to integer comparison checks while iterating over
CartesianIndicesto be the most expensive step: