JuliaMath / NaNMath.jl

Julia math built-ins which return NaN and accumulator functions which ignore NaN
Other
53 stars 28 forks source link

StackOverflowError for pow(::Float32, ::Float64) #47

Closed torfjelde closed 2 years ago

torfjelde commented 3 years ago

pow(::Float32, ::Float64) results in a StackOverflowError due to the use of float in the default implementation: https://github.com/mlubin/NaNMath.jl/blob/0fc4df8442fcefebe8efe490781fce5663c03b02/src/NaNMath.jl#L23-L25

Maybe there ought to be a promote here?

mlubin commented 3 years ago

That could work, feel free to open a PR.

mlubin commented 2 years ago

Closed by https://github.com/mlubin/NaNMath.jl/pull/50 and tagged a new release